Change in vdsm[master]: Don't down bonds and nics when adding vlan or resizing

danken at redhat.com danken at redhat.com
Wed Aug 21 21:22:14 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Don't down bonds and nics when adding vlan or resizing
......................................................................


Patch Set 13:

(2 comments)

....................................................
File tests/functional/networkTests.py
Line 51:     pass
Line 52: 
Line 53: 
Line 54: @contextmanager
Line 55: def nonChangingOperstate(device):
this is obviously raceful. I know that you know it, but future reviewers should, too. Please note that we do not care, as the race that much since the race produces only false successes, not annoying false failures.
Line 56:     def changed(dev, changes):
Line 57:         status = operstate(dev)
Line 58:         while not done:
Line 59:             try:


Line 56:     def changed(dev, changes):
Line 57:         status = operstate(dev)
Line 58:         while not done:
Line 59:             try:
Line 60:                 newState = operstate(dev)
this is a tight loop that only narrows the race without eliminating it. I hate to consume so much Jenkins resources... Which sleep interval here would still catch the current bug?
Line 61:             except IOError as ioe:
Line 62:                 _, message = ioe.args
Line 63:                 changes.append(message)
Line 64:                 break


-- 
To view, visit http://gerrit.ovirt.org/17491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3075a2e65f06416c840c6a98689b77555b22e5d
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Ĺ ebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list