Change in vdsm[master]: Remove redundant check that causes lvm cache to refresh ever...

fsimonce at redhat.com fsimonce at redhat.com
Wed Aug 21 18:23:10 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: Remove redundant check that causes lvm cache to refresh every volume creation
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/storage/volume.py
Line 420:                     srcImgUUID = imgUUID
Line 421: 
Line 422:                 volParent = cls(repoPath, sdUUID, srcImgUUID, srcVolUUID)
Line 423:                 # Override the size with the size of the parent
Line 424:                 size = volParent.getSize()
Yes, I just spoke with Ayal and he said that he moved it by mistake.
Line 425: 
Line 426:                 if imgUUID != srcImgUUID:
Line 427:                     volParent.share(imgPath)
Line 428:                     volParent = cls(repoPath, sdUUID, imgUUID, srcVolUUID)


-- 
To view, visit http://gerrit.ovirt.org/18274
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f3b6ca8313070d0345b5f76ebb0b3d9772d14f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list