Change in vdsm[master]: Add support for transient disk

deepakcs at linux.vnet.ibm.com deepakcs at linux.vnet.ibm.com
Wed Aug 21 12:05:27 UTC 2013


Deepak C Shetty has posted comments on this change.

Change subject: Add support for transient disk
......................................................................


Patch Set 1:

(2 comments)

Yeah, i was not clear on what exactly to do to disable migration. Pls enlighten me.

....................................................
File vdsm/vm.py
Line 1378:                 ((self.apparentsize + constants.MEGAB - 1) / constants.MEGAB))
Line 1379: 
Line 1380:     @property
Line 1381:     def networkDev(self):
Line 1382:         if self.transientDisk:
This is just to ensure that if by any chance the volInfo indicates a network type disk.. it should still work if transientDisk is also enabled... It should never happen, but it works like a double-check. I did remove the volInfo to {} but just in case if someone in some other flow forgets to do that!
Line 1383:             return False
Line 1384:         try:
Line 1385:             return self.volumeInfo['volType'] == "network"
Line 1386:         except AttributeError:


Line 1391:     def blockDev(self):
Line 1392:         if self.networkDev:
Line 1393:             return False
Line 1394:         if self.transientDisk:
Line 1395:             return False
Why do you even want to go thru the isBlockdevice logic if its already known to be a transient disk... hence the check
Line 1396: 
Line 1397:         if self._blockDev is None:
Line 1398:             try:
Line 1399:                 self._blockDev = utils.isBlockDevice(self.path)


-- 
To view, visit http://gerrit.ovirt.org/18326
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Deepak C Shetty <deepakcs at linux.vnet.ibm.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Liron Ar <laravot at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list