Change in vdsm[master]: vdsm-gluster: Added gluster volume geo-replication start verb

barumuga at redhat.com barumuga at redhat.com
Wed Aug 21 10:50:14 UTC 2013


Bala.FA has posted comments on this change.

Change subject: vdsm-gluster: Added gluster volume geo-replication start verb
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

....................................................
Commit Message
Line 3: AuthorDate: 2013-08-07 17:11:43 +0530
Line 4: Commit:     Timothy Asir <tjeyasin at redhat.com>
Line 5: CommitDate: 2013-08-07 17:12:22 +0530
Line 6: 
Line 7: vdsm-gluster: Added gluster volume geo-replication start verb
prefix with gluster:

This patch deals with start/stop of geo-rep session, but commit msg is not
Line 8: 
Line 9: Start the geo-replication session between the hosts.
Line 10: 
Line 11: Start distributed geo-replication on all the nodes that are a part


....................................................
File client/vdsClientGluster.py
Line 429:         masterVolName = params.get('masterVolName', '')
Line 430:         slaveHost = params.get('slaveHost', '')
Line 431:         slaveVolName = params.get('slaveVolName', '')
Line 432:         if not(masterVolName and slaveHost and slaveVolName):
Line 433:             raise ValueError
What will happen if one of the element is empty from engine?  we can use vdsClient as a test tool too.  So don't check here.  The verb should handle them properly.

This applies below verbs too
Line 434: 
Line 435:         status = self.s.glusterVolumeGeoRepStart(masterVolName,
Line 436:                                                  slaveHost,
Line 437:                                                  slaveVolName)


Line 745:               'start volume geo-replication'
Line 746:               )),
Line 747:          'glusterVolumeGeoRepStop': (
Line 748:              serv.do_glusterVolumeGeoRepStop,
Line 749:              ('masterVolName=<master_volume_name> slaveHost=<slave_host> '
Change volumeName, remoteHost, remoteVolume instead of masterVolName, slaveHost, slaveVolName everywhere
Line 750:               'slaveVolName=<slave_volume_name>\n\t'
Line 751:               '<master_volume_name> is an existing volume name in the '
Line 752:               'master node\n\t'
Line 753:               '<slave_host> is slave host name\n\t'


....................................................
File vdsm/gluster/api.py
Line 287:         status = self.svdsmProxy.glusterServicesGet(serviceNames)
Line 288:         return {'services': status}
Line 289: 
Line 290:     @exportAsVerb
Line 291:     def volumeGeoRepStart(self, masterVolName, slaveHost, slaveVolName,
Please add force option
Line 292:                           options=None):
Line 293:         self.svdsmProxy.glusterVolumeGeoRepStart(masterVolName,
Line 294:                                                  slaveHost,
Line 295:                                                  slaveVolName)


Line 294:                                                  slaveHost,
Line 295:                                                  slaveVolName)
Line 296: 
Line 297:     @exportAsVerb
Line 298:     def volumeGeoRepStop(self, masterVolName, slaveHost, slaveVolName,
same here
Line 299:                          options=None):
Line 300:         self.svdsmProxy.glusterVolumeGeoRepStop(masterVolName,
Line 301:                                                 slaveHost,
Line 302:                                                 slaveVolName)


-- 
To view, visit http://gerrit.ovirt.org/17766
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf03c748cf9fe28efe7d407727cd52da20701c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Aravinda VK <avishwan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: humble devassy <hchiramm at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list