Change in vdsm[master]: Get rid of mutables(lists) as default parameters

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Aug 21 10:13:02 UTC 2013


Vinzenz Feenstra has posted comments on this change.

Change subject: Get rid of mutables(lists) as default parameters
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File vdsm/BindingXMLRPC.py
Line 213:     def vmCreate(self, vmParams):
Line 214:         vm = API.VM(vmParams['vmId'])
Line 215:         return vm.create(vmParams)
Line 216: 
Line 217:     def getVMList(self, fullStatus=False, vmList=None):
this brakes getVmList
Line 218:         api = API.Global()
Line 219:         return api.getVMList(fullStatus, vmList)
Line 220: 
Line 221:     def vmPause(self, vmId):


-- 
To view, visit http://gerrit.ovirt.org/18356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I911485cf30d587f5b6b8bf44cf3552c1517abfd5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list