Change in vdsm[master]: Change of ConfigWriter._createConfFile parameters

psebek at redhat.com psebek at redhat.com
Wed Aug 21 06:53:49 UTC 2013


Petr Šebek has posted comments on this change.

Change subject: Change of ConfigWriter._createConfFile parameters
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 539:             if not iface.mtu:
Line 540:                 mtu = confParams.get('MTU', None)
Line 541:                 if mtu:
Line 542:                     mtu = int(mtu)
Line 543:         return iface.ip
It is easier to return IpConfig object than return namedtuple then from it create IpConfig object and then pass it to the _createConfFile. I'm not sure if I don't mess with other occurences of IpConfig when I overwrite the attributes, though.
Line 544: 
Line 545:     def removeNic(self, nic):
Line 546:         cf = netinfo.NET_CONF_PREF + nic
Line 547:         self._backup(cf)


-- 
To view, visit http://gerrit.ovirt.org/18331
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae5ec15048ed52170371dda1d0fa9b90d51838e3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Šebek <psebek at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Petr Šebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list