Change in vdsm[master]: Don't down bonds and nics when adding vlan or resizing

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Wed Aug 21 05:37:38 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Don't down bonds and nics when adding vlan or resizing
......................................................................


Patch Set 12: Code-Review+1

(1 comment)

....................................................
File tests/functional/networkTests.py
Line 660:                     createBondedNetAndCheck(3,
Line 661:                                             {'nics': nics[1:],
Line 662:                                              'options': 'mode=3 miimon=250'})
Line 663: 
Line 664:                 # Add a network chaning bond options
s/chaning/changing/
Line 665:                 with self.assertRaises(OperStateChangedError):
Line 666:                     with nonChangingOperstate(BONDING_NAME):
Line 667:                         createBondedNetAndCheck(4,
Line 668:                                                 {'nics': nics[1:],


-- 
To view, visit http://gerrit.ovirt.org/17491
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3075a2e65f06416c840c6a98689b77555b22e5d
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Ĺ ebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list