Change in vdsm[master]: Removing validate sd from spm verbs which calls ckvg and ref...

abaron at redhat.com abaron at redhat.com
Tue Aug 20 13:17:05 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Removing validate sd from spm verbs which calls ckvg and refreshes the domain metadata on the spm even though the spm already controls the changes (i.e. a lot of redundant time is wasted)
......................................................................


Patch Set 1:

(4 comments)

....................................................
File vdsm/storage/hsm.py
Line 1671:         """
Line 1672:         Upload an image to a remote endpoint using the specified method and
Line 1673:         methodArgs.
Line 1674:         """
Line 1675:         self.validateSdUUID(sdUUID)
Originally when I wrote it these weren't in the code base, so rebase issue.
However, I wanted in any event to do this only where it is worth it, not sure it matters here, but since these are new anyway then probably can be removed.
Line 1676:         pool = self.getPool(spUUID)
Line 1677:         # NOTE: this could become an hsm task
Line 1678:         self._spmSchedule(spUUID, "uploadImage", pool.uploadImage,
Line 1679:                           methodArgs, sdUUID, imgUUID, volUUID)


Line 1683:         """
Line 1684:         Download an image from a remote endpoint using the specified method
Line 1685:         and methodArgs.
Line 1686:         """
Line 1687:         self.validateSdUUID(sdUUID)
same
Line 1688:         pool = self.getPool(spUUID)
Line 1689:         # NOTE: this could become an hsm task, in such case the LV extension
Line 1690:         # required to prepare the destination should go through the mailbox.
Line 1691:         self._spmSchedule(spUUID, "downloadImage", pool.downloadImage,


Line 1857:         except se.StoragePoolUnknown:
Line 1858:             pool = sp.StoragePool(spUUID, self.taskMng)
Line 1859:         else:
Line 1860:             raise se.StoragePoolConnected(spUUID)
Line 1861: 
I just didn't want to mess around with this flow and even think about the implications.
This isn't called often enough to justify the risk.
Line 1862:         self.validateSdUUID(masterDom)
Line 1863: 
Line 1864:         if hostId is not None:
Line 1865:             misc.validateN(hostId, 'hostId')


Line 2717:         :returns: a dict containing the information about the domain.
Line 2718:         :rtype: dict
Line 2719:         """
Line 2720:         vars.task.setDefaultException(
Line 2721:             se.StorageDomainActionError("sdUUID=%s" % sdUUID))
Fresh MD, don't want to change other things.
Purpose of this patch is to improve performance of most flows by removing redundant calls, not start messing around where it is needed (for whatever reason)
Line 2722:         dom = self.validateSdUUID(sdUUID)
Line 2723:         # getSharedLock(connectionsResource...)
Line 2724: 
Line 2725:         vars.task.getSharedLock(STORAGE, sdUUID)


-- 
To view, visit http://gerrit.ovirt.org/18275
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf597a9e53dad04ad7a01fc1d5ceb8a180a542f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list