Change in vdsm[master]: Functional Tests [1/3]: Added module for dummy nics

amuller at redhat.com amuller at redhat.com
Tue Aug 20 11:44:29 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Functional Tests [1/3]: Added module for dummy nics
......................................................................


Patch Set 3:

(5 comments)

....................................................
File tests/functional/dummy.py
Line 16: #
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19: import random
Line 20: from contextlib import contextmanager
Done
Line 21: 
Line 22: from nose.plugins.skip import SkipTest
Line 23: from vdsm.ipwrapper import linkAdd, linkDel, addrAdd, linkSet, IPRoute2Error
Line 24: 


Line 19: import random
Line 20: from contextlib import contextmanager
Line 21: 
Line 22: from nose.plugins.skip import SkipTest
Line 23: from vdsm.ipwrapper import linkAdd, linkDel, addrAdd, linkSet, IPRoute2Error
Done
Line 24: 
Line 25: 
Line 26: def create():
Line 27:     """


Line 60:     except IPRoute2Error:
Line 61:         raise SkipTest('Failed to set device ip')
Line 62: 
Line 63: 
Line 64: def setLinkUp(dummyName):
For anyone bored enough to go through these comments: We had a quick chat and decided to agree to disagree and keep the current implementation.
Line 65:     _setLinkState(dummyName, 'up')
Line 66: 
Line 67: 
Line 68: def setLinkDown(dummyName):


....................................................
File tests/functional/networkTests.py
Line 22:                         expandPermutations, permutations)
Line 23: from testValidation import RequireDummyMod, ValidateRunningAsRoot
Line 24: 
Line 25: from utils import cleanupNet, restoreNetConfig, SUCCESS, VdsProxy
Line 26: from dummy import dummyIf
Done
Line 27: 
Line 28: 
Line 29: NETWORK_NAME = 'test-network'
Line 30: VLAN_ID = '27'


....................................................
File tests/functional/utils.py
Line 30: SUCCESS = 0
Line 31: Qos = namedtuple('Qos', 'inbound outbound')
Line 32: 
Line 33: 
Line 34: ip = utils.CommandPath('ip',
Done
Line 35:                        '/sbin/ip',      # EL6
Line 36:                        '/usr/sbin/ip',  # Fedora
Line 37:                        )
Line 38: 


-- 
To view, visit http://gerrit.ovirt.org/18039
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c7ed4110cd8d45a3fb7a9cc2cd2dc07004e96b9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list