Change in vdsm[master]: vdsm: Reboot capability for VM

asegurap at redhat.com asegurap at redhat.com
Tue Aug 20 08:36:09 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: vdsm: Reboot capability for VM
......................................................................


Patch Set 17: Code-Review-1

(1 comment)

-1 for visibility, awaiting answer.

....................................................
File vdsm/vm.py
Line 1631:             super(VmPowerDown, self).start()
Line 1632: 
Line 1633:             return {'status': {'code': doneCode['code'],
Line 1634:                                'message': self.info['returnMsg']}}
Line 1635:         except:
Do you want to catch BaseExceptions or only Exceptions (I'd guess the latter)?
Line 1636:             self.vm.log.error("{action} failed".format(**self.info),
Line 1637:                               exc_info=True)
Line 1638:             message = 'Failed to {action} VM.'
Line 1639:             if not self.force:


-- 
To view, visit http://gerrit.ovirt.org/15829
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12737e363a80679ffb1db55f14eaee158312d7da
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list