Change in vdsm[master]: storage: kill ongoing operations on exit
abaron at redhat.com
abaron at redhat.com
Tue Aug 20 06:18:07 UTC 2013
Ayal Baron has posted comments on this change.
Change subject: storage: kill ongoing operations on exit
......................................................................
Patch Set 2:
(4 comments)
....................................................
File vdsm/storage/blockSD.py
Line 1059: fileUtils.createdir(masterDir)
Line 1060:
Line 1061: masterfsdev = lvm.lvPath(self.sdUUID, MASTERLV)
Line 1062: cmd = [constants.EXT_FSCK, "-p", masterfsdev]
Line 1063: (rc, out, err) = misc.execCmd(cmd, sudo=True)
why not kill on exit here as well?
Line 1064: # fsck exit codes
Line 1065: # 0 - No errors
Line 1066: # 1 - File system errors corrected
Line 1067: # 2 - File system errors corrected, system should
Line 1096: raise se.BlockStorageDomainMasterMountError(masterfsdev, rc, out)
Line 1097:
Line 1098: cmd = [constants.EXT_CHOWN, "%s:%s" %
Line 1099: (constants.METADATA_USER, constants.METADATA_GROUP), masterDir]
Line 1100: (rc, out, err) = misc.execCmd(cmd, sudo=True)
and here
Line 1101: if rc != 0:
Line 1102: self.log.error("failed to chown %s", masterDir)
Line 1103:
Line 1104: @classmethod
....................................................
File vdsm/storage/sp.py
Line 2076: vol.prepare(rw=True, setrw=False)
Line 2077: try:
Line 2078: if method.lower() == "wget":
Line 2079: cmd = [constants.EXT_WGET, "-O", targetPath, srcPath]
Line 2080: (rc, out, err) = misc.execCmd(cmd, sudo=False, killOnExit=True)
I wonder if we should wrap execCmd in sp.py to change the default.
Line 2081:
Line 2082: if rc:
Line 2083: self.log.error("uploadVolume - error while trying to "
Line 2084: "retrieve: %s into: %s, stderr: %s" %
....................................................
File vdsm/storage/storage_mailbox.py
Line 268: self.start()
Line 269:
Line 270: def _initMailbox(self):
Line 271: # Sync initial incoming mail state with storage view
Line 272: (rc, out, err) = misc.execCmd(self._inCmd, sudo=False, raw=True,
here also I wonder if we shouldn't just wrap execCmd
Line 273: killOnExit=True)
Line 274: if rc == 0:
Line 275: self._incomingMail = out
Line 276: self._init = True
--
To view, visit http://gerrit.ovirt.org/18074
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6ff67cb687494099e332d2d7b1eb3a293d1b4e4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list