Change in vdsm[master]: One shot prepare.
ewarszaw at redhat.com
ewarszaw at redhat.com
Mon Aug 19 17:50:13 UTC 2013
Eduardo has posted comments on this change.
Change subject: One shot prepare.
......................................................................
Patch Set 10:
(3 comments)
....................................................
File vdsm/storage/blockSD.py
Line 1033: Creates a compatiblity layer for vdsm and qemu-img use.
Line 1034:
Line 1035: srcImgPath: Dir where the image volumes are.
Line 1036: """
Line 1037: sdRunDir = os.path.join("/var/run/vdsm/storage", self.sdUUID)
I totally agree with you. But danken was unable to determine the optimal place for this constant.
He asked to be merged in this form until a rework in progress on the constants will be done, not by our team.
I presume that we need to wait until he will be back online.
Line 1038: imgRunDir = os.path.join(sdRunDir, imgUUID)
Line 1039: fileUtils.createdir(imgRunDir)
Line 1040: for volUUID in volUUIDs:
Line 1041: srcVol = os.path.join(srcImgPath, volUUID)
Line 1061: If the image is based on a template image it will be activated.
Line 1062: """
Line 1063: volUUIDs = sd.getVolsOfImage(allVols, imgUUID).keys()
Line 1064: lvm.activateLVs(self.sdUUID, volUUIDs)
Line 1065: vgDir = os.path.join("/dev", self.sdUUID)
I agree.
Same as above.
Line 1066: return self.linkRunImage(vgDir, imgUUID, volUUIDs)
Line 1067:
Line 1068: def getVolumeLease(self, imgUUID, volUUID):
Line 1069: """
....................................................
File vdsm/storage/fileSD.py
Line 446: # set. We have to set it here if we want qemu-kvm to write to old
Line 447: # NFS volumes. In theory it is necessary to fix the permission
Line 448: # of the leaf only but to not introduce an additional requirement
Line 449: # (ordered volUUIDs) we fix them all.
Line 450: imgDir = os.path.join(self.mountpoint, self.sdUUID, sd.DOMAIN_IMAGES,
We need to be totally independent from SP.
Line 451: imgUUID)
Line 452: volUUIDs = sd.getVolsOfImage(allVols, imgUUID).keys()
Line 453: volPaths = tuple(os.path.join(imgDir, v) for v in volUUIDs)
Line 454: for volPath in volPaths:
--
To view, visit http://gerrit.ovirt.org/4220
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id47db9c53199385dd5d08586e4782ea23885eb72
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Elad Ben Aharon <eladba1990 at gmail.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list