Change in vdsm[master]: storage: kill ongoing operations on exit

fsimonce at redhat.com fsimonce at redhat.com
Mon Aug 19 15:16:22 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: storage: kill ongoing operations on exit
......................................................................


Patch Set 1:

(1 comment)

....................................................
File lib/vdsm/utils.py
Line 517:     return [l[:-1] if l.endswith('\n') else l for l in lines]
Line 518: 
Line 519: 
Line 520: def watchCmd(command, stop, cwd=None, data=None, recoveryCallback=None,
Line 521:              nice=None, ioclass=None, execCmdLogger=logging.root,
right, but the other mistake is in 'execCmd' where it should be False by default.
Line 522:              killOnExit=False):
Line 523:     """
Line 524:     Executes an external command, optionally via sudo with stop abilities.
Line 525:     """


-- 
To view, visit http://gerrit.ovirt.org/18074
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6ff67cb687494099e332d2d7b1eb3a293d1b4e4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list