Change in vdsm[master]: vdsmapi-schema: optional/required params fix

asegurap at redhat.com asegurap at redhat.com
Mon Aug 19 14:04:01 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: vdsmapi-schema: optional/required params fix
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

....................................................
File vdsm_api/vdsmapi-schema.json
Line 2203: #
Line 2204: # Additional parameters for VM video devices.
Line 2205: #
Line 2206: # @vram:  Specify the amount of video RAM available to the device
Line 2207: #         in KB. Passed to any driver, currently has effect on @qxl devices only 
Please, remove the trailing whitespace.
"currently it only has effect"
Line 2208: #
Line 2209: # @heads:  #optional Specify the amount of monitors that will use single
Line 2210: #          pci device.  Currently relevant for @qxl devices only
Line 2211: #


Line 2528: # @spicevmc:    Use smartcard channel of SPICE
Line 2529: #
Line 2530: # Since: 4.10.3
Line 2531: ##
Line 2532: {'enum': 'VmSmartcardDeviceProtocol', 'data': ['spicevmc']}
I can see in http://libvirt.org/formatdomain.html#elementsSmartcard that tcp is another protocol type. Do we support it?
Line 2533: 
Line 2534: ##
Line 2535: # @VmSmartcardDeviceMode:
Line 2536: #


Line 2556: # Since: 4.10.3
Line 2557: ##
Line 2558: {'type': 'VmSmartcardDeviceSpecParams',
Line 2559:  'data': {'mode': 'VmSmartcardDeviceMode',
Line 2560:           'type': 'VmSmartcardDeviceProtocol'}}
Isn't the protocol only required when using passthrough and not when using @host? In that case, I don't think that protocol should be a mandatory parameter.
Line 2561: 
Line 2562: ##
Line 2563: # @VmSmartcardDeviceType:
Line 2564: #


-- 
To view, visit http://gerrit.ovirt.org/18056
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4f9e123da73b0a326ce0762702e5ab7a3a0a583
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list