Change in vdsm[master]: Handling ssl error specifically instead of printing all stac...

fsimonce at redhat.com fsimonce at redhat.com
Mon Aug 19 12:26:20 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: Handling ssl error specifically instead of printing all stacktrace
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Let's just use the regular log string formatting and merge this.

....................................................
File vdsm/BindingXMLRPC.py
Line 67:             while self._enabled:
Line 68:                 try:
Line 69:                     self.server.handle_request()
Line 70:                 except SSLError as e:
Line 71:                     self.log.error("xml-rpc SSL error: {0}. from {1}".format(
I love the idea of this patch.

But I don't think it's the right moment to stop using the string formatting provided by log.error(...).
Line 72:                                    e.message, self.server.lastClient))
Line 73:                 except Exception as e:
Line 74:                     if e[0] != EINTR:
Line 75:                         self.log.error("xml-rpc handler exception",


-- 
To view, visit http://gerrit.ovirt.org/17917
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47556f62aef6f63a66fa47ecb4d693082da4dee1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list