Change in vdsm[master]: netconf: enable multiple gateways for iproute2 configurator

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon Aug 19 08:32:32 UTC 2013


Mark Wu has posted comments on this change.

Change subject: netconf: enable multiple gateways for iproute2 configurator
......................................................................


Patch Set 4:

(1 comment)

....................................................
File vdsm/sourceRoute.py
Line 150:         # its source
Line 151:         rules += [rule for rule in allRules if rule.source == network]
Line 152: 
Line 153:         return rules
Line 154: 
Yes, it makes sense.  I will fix it in next patch. Thanks!
Line 155:     def remove(self):
Line 156:         logging.info("Removing gateway - device: %s" % self.device)
Line 157: 
Line 158:         rules = self._getRules(self.device)


-- 
To view, visit http://gerrit.ovirt.org/16276
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I76e1225caffdb2de3073041e541c7c978eefb396
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list