Change in vdsm[master]: tests: setupNetworks add net bond breaking and resizing.

gvallare at redhat.com gvallare at redhat.com
Mon Aug 19 07:38:06 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: tests: setupNetworks add net bond breaking and resizing.
......................................................................


Patch Set 5:

I changed the wording of the commit msg, I gave a try to refactor common code across the three tests but I wasn't fully satisfied of the result it only meant to wrap some code in external functions and move the asserts around, which frankly I dislike.

-- 
To view, visit http://gerrit.ovirt.org/17634
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e031599ac4457cc24cb9d142110e1781325912f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list