Change in vdsm[master]: Add iproute2 configurator

asegurap at redhat.com asegurap at redhat.com
Sat Aug 17 09:40:28 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Add iproute2 configurator
......................................................................


Patch Set 8: Code-Review-1

(7 comments)

-1 for visibility of the comments.

....................................................
File lib/vdsm/ipwrapper.py
Line 249:     command += rule
Line 250:     _execCmd(command)
Line 251: 
Line 252: 
Line 253: def addrAdd(addr):
We could add a first parameter 'dev'.
Line 254:     command = [_IP_BINARY.cmd, 'addr', 'add'] + addr
Line 255:     _execCmd(command)
Line 256: 
Line 257: 


Line 254:     command = [_IP_BINARY.cmd, 'addr', 'add'] + addr
Line 255:     _execCmd(command)
Line 256: 
Line 257: 
Line 258: def addrFlush(addr):
We could add a first parameter 'dev'.
Line 259:     command = [_IP_BINARY.cmd, 'addr', 'flush'] + addr
Line 260:     _execCmd(command)
Line 261: 
Line 262: 


Line 259:     command = [_IP_BINARY.cmd, 'addr', 'flush'] + addr
Line 260:     _execCmd(command)
Line 261: 
Line 262: 
Line 263: def linkAdd(link):
We could add a first parameter 'dev'.
Line 264:     command = [_IP_BINARY.cmd, 'link', 'add'] + link
Line 265:     _execCmd(command)
Line 266: 
Line 267: 


Line 264:     command = [_IP_BINARY.cmd, 'link', 'add'] + link
Line 265:     _execCmd(command)
Line 266: 
Line 267: 
Line 268: def linkSet(link):
We could add a first parameter 'dev'.
Line 269:     command = [_IP_BINARY.cmd, 'link', 'set'] + link
Line 270:     _execCmd(command)
Line 271: 
Line 272: 


Line 269:     command = [_IP_BINARY.cmd, 'link', 'set'] + link
Line 270:     _execCmd(command)
Line 271: 
Line 272: 
Line 273: def linkDel(link):
We could add a first parameter 'dev'.
Line 274:     command = [_IP_BINARY.cmd, 'link', 'del'] + link


....................................................
File vdsm/netconf/iproute2.py
Line 56:                 slave.configure(**opts)
Line 57: 
Line 58:         self.configApplier.setIfaceConfigAndUp(bond)
Line 59: 
Line 60:     def editBonding(self, bond, _netinfo):
After the editbondings patch I made I'll make a followup patch for this.
Line 61:         self.configApplier.ifdown(bond)
Line 62:         for nic in _netinfo.getNicsForBonding(bond.name):
Line 63:             slave = Nic(nic, self, _netinfo=_netinfo)
Line 64:             self.configApplier.removeBondSlave(bond, slave)


Line 181:         try:
Line 182:             ipwrapper.linkAdd(['link', vlan.device.name, 'name', vlan.name,
Line 183:                                'type', 'vlan', 'id', vlan.tag])
Line 184:         except ipwrapper.IPRoute2Error as e:
Line 185:             if 'File exists' in e.message[0]:
Does this happen often? It could be a sign of us needlessly reconfiguring.
Line 186:                 pass
Line 187:             else:
Line 188:                 raise
Line 189: 


-- 
To view, visit http://gerrit.ovirt.org/15301
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I762cfa30f78c5a46507b86f53e98bcf79dfc5844
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Petr Ĺ ebek <psebek at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list