Change in vdsm[master]: Introducing hidden_vlans configurable.

apahim at redhat.com apahim at redhat.com
Fri Aug 16 12:52:13 UTC 2013


Amador Pahim has posted comments on this change.

Change subject: Introducing hidden_vlans configurable.
......................................................................


Patch Set 4:

IMHO, I do not agree. Removing hidden_nics and hidden_bonds from config will reintroduce in users environments nics and bonds they were avoiding. upgrade can manage that, but thinking in backup/restore of config file, it can be considered a regression after all.

-- 
To view, visit http://gerrit.ovirt.org/18082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4340936fb998c5ab9ee46e16a16ae15461176f2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list