Change in vdsm[master]: [1/3] Fix getVlanID() and getVlanDevice().
asegurap at redhat.com
asegurap at redhat.com
Thu Aug 15 22:57:45 UTC 2013
Antoni Segura Puimedon has posted comments on this change.
Change subject: [1/3] Fix getVlanID() and getVlanDevice().
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Just one minor thing for more codebase consistency. Sorry I didn't realize it until now.
....................................................
File lib/vdsm/netinfo.py
Line 535:
Line 536:
Line 537: def getVlanDevice(vlan):
Line 538: """ Return the device of the given VLAN. """
Line 539: cmd = [constants.EXT_IP, '-o', 'link', 'show', 'dev', vlan]
Since these two use /sbin/ip, they should probably have the command execution be moved to lib/vdsm/ipwrapper.
Line 540: rc, out, err = utils.execCmd(cmd)
Line 541:
Line 542: if rc != 0:
Line 543: raise Exception(err)
--
To view, visit http://gerrit.ovirt.org/18180
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieab0f44cf4c4f6f16f81435cb732ccacf57b0767
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list