Change in vdsm[master]: netconf: Simplify addSourceRoute arguments

asegurap at redhat.com asegurap at redhat.com
Thu Aug 15 11:06:19 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: netconf: Simplify addSourceRoute arguments
......................................................................


Patch Set 1: Code-Review+1

We'll be doing the variable resolution twice but the added readability and simplicity is more important, IMHO.

-- 
To view, visit http://gerrit.ovirt.org/18168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1bf06f865abbed8cf1fdcca909cbf78c6e5f66f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list