Change in vdsm[master]: Introducing hidden_vlans configurable

asegurap at redhat.com asegurap at redhat.com
Wed Aug 14 22:47:47 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Introducing hidden_vlans configurable
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File lib/vdsm/netinfo.py
Line 141: 
Line 142: def vlans():
Line 143:     hidden_vlans = config.get('vars', 'hidden_vlans').split(',')
Line 144:     return [b.split('/')[-1] for b in iglob('/sys/class/net/*.*')
Line 145:             if b.split('/')[-1] not in hidden_vlans]
instead of not in hidden_vlans, it should use _mach_name.
Line 146: 
Line 147: 
Line 148: def bridges():
Line 149:     return [b.split('/')[-2] for b in iglob('/sys/class/net/*/bridge')


-- 
To view, visit http://gerrit.ovirt.org/18082
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4340936fb998c5ab9ee46e16a16ae15461176f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list