Change in vdsm[master]: Add vdsm upstart jobs

Alon Bar-Lev alonbl at redhat.com
Wed Aug 14 10:44:51 UTC 2013


Alon Bar-Lev has posted comments on this change.

Change subject: Add vdsm upstart jobs
......................................................................


Patch Set 2:

(1 comment)

....................................................
File vdsm/vdsmd.upstart.in
Line 10: nice -20
Line 11: respawn
Line 12: 
Line 13: pre-start script
Line 14:     "@LIBEXECDIR@/vdsmd_init_common.sh" --start-needed-srv "ntp open-iscsi multipath-tools wdmd sanlock portmap libvirt-bin supervdsmd"
Few thoughts...

First, I do not like the use of the common code to start services. I think that each distribution has its own method of doing that and as this file is distribution specific best to use distribution tools so that maintainer will be able to maintain without knowledge of package internals.

Second... I read the upstart manual... and there is an option just to start services... what is the problem in that? I asking as I never actually used upstart...

 # statd - NSM status monitor
 description   "NSM status monitor"
 author                "Steve Langasek <steve.langasek at canonical.com>"
 start on (started portmap or mounting TYPE=nfs)
 stop on stopping portmap
 expect fork
 respawn
 env DEFAULTFILE=/etc/default/nfs-common
 pre-start script
     if [ -f "$DEFAULTFILE" ]; then
         . "$DEFAULTFILE"
     fi
     [ "x$NEED_STATD" != xno ] || { stop; exit 0; }
     start portmap || true
     status portmap | grep -q start/running
     exec sm-notify
 end script
Line 15:     "@LIBEXECDIR@/vdsmd_init_common.sh" --pre-start
Line 16: end script
Line 17: 
Line 18: # All commands called inside this script section except the daemon itself


-- 
To view, visit http://gerrit.ovirt.org/17812
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id68ec0197bd1e09100f5da96ac4db24f2b90753a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list