Change in vdsm[master]: Killing vdsm when first communication to libvirt fails

bazulay at redhat.com bazulay at redhat.com
Tue Aug 13 11:49:34 UTC 2013


Barak Azulay has posted comments on this change.

Change subject: Killing vdsm when first communication to libvirt fails
......................................................................


Patch Set 3: Code-Review-1

This happens only when libvirt is stopped manually while vdsm is up, so vdsm will reset itself and it will be caught by the watchdog, so this fix will loop around reseting vdsm (not good)  
I think a better idea will be to loop over the libvirt connection on the recovering thread. this way the vdsm will still return the "recovering" status and the libvirt connection will be re-established after libvirt start

-- 
To view, visit http://gerrit.ovirt.org/17617
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80745e04c7cce50e4cd8ce12628131b76d0659a7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Martin Polednik <mpoledni at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list