Change in vdsm[master]: vdsmd and supervdsmd: extract common init tasks and add init...

sbonazzo at redhat.com sbonazzo at redhat.com
Mon Aug 12 08:09:31 UTC 2013


Sandro Bonazzola has posted comments on this change.

Change subject: vdsmd and supervdsmd: extract common init tasks and add init adapter
......................................................................


Patch Set 13:

(2 comments)

....................................................
File vdsm/daemonAdapter
Line 59: 
Line 60:     cmd = [args.target[0]] + args.targetOptions
Line 61: 
Line 62:     if args.redirect:
Line 63:         # Redirction should be in last minute, otherwise it would swallow
Redirction -> Redirection
Line 64:         # error messages.
Line 65:         os.close(0)
Line 66:         os.open(args.redirect, os.O_RDONLY)
Line 67:         os.close(1)


....................................................
File vdsm/supervdsmServer.py
Line 24: import errno
Line 25: from functools import wraps
Line 26: import threading
Line 27: import re
Line 28: import getopt
why getopt and not argparse like in daemonAdapter?
Line 29: import signal
Line 30: import logging
Line 31: import logging.config
Line 32: 


-- 
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Mei Liu <liumbj at linux.vnet.ibm.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list