Change in vdsm[master]: tests: adding missing cleanupNet and refined testQosNetwork.
asegurap at redhat.com
asegurap at redhat.com
Sun Aug 11 19:40:25 UTC 2013
Antoni Segura Puimedon has posted comments on this change.
Change subject: tests: adding missing cleanupNet and refined testQosNetwork.
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
For more safety.
....................................................
File tests/functional/networkTests.py
Line 340: self.assertEqual(qos['qosOutbound'], qosOutbound)
Line 341:
Line 342: status, msg = self.vdsm_net.delNetwork(NETWORK_NAME)
Line 343:
Line 344: self.assertEqual(status, SUCCESS, msg)
I want also self.assertFalse(self.vdsm_net.networkExists(NETWORK_NAME)
and we should do taht after the delNetwork in 367
Line 345:
Line 346: @cleanupNet
Line 347: @permutations([[True], [False]])
Line 348: @RequireDummyMod
--
To view, visit http://gerrit.ovirt.org/17941
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2fa9619a38acdfcc19f889329d375f868a3e921e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list