Change in vdsm[master]: tests: adding missing cleanupNet and refined testQosNetwork.

gvallare at redhat.com gvallare at redhat.com
Sun Aug 11 19:34:48 UTC 2013


Giuseppe Vallarelli has uploaded a new change for review.

Change subject: tests: adding missing cleanupNet and refined testQosNetwork.
......................................................................

tests: adding missing cleanupNet and refined testQosNetwork.

Some additional cleanupNet were necessary on some tests
which might, on possible failure, make the env dirty.
Added the deletion of network created in the testQosNetwork.

Change-Id: I2fa9619a38acdfcc19f889329d375f868a3e921e
Signed-off-by: Giuseppe Vallarelli <gvallare at redhat.com>
---
M tests/functional/networkTests.py
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/17941/1

diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 9e35120..61b88a8 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -320,6 +320,7 @@
                                                    nics=nics)
             self.assertEqual(status, SUCCESS, msg)
 
+    @cleanupNet
     @RequireDummyMod
     @ValidateRunningAsRoot
     def testQosNetwork(self):
@@ -338,6 +339,11 @@
             self.assertEqual(qos['qosInbound'], qosInbound)
             self.assertEqual(qos['qosOutbound'], qosOutbound)
 
+            status, msg = self.vdsm_net.delNetwork(NETWORK_NAME)
+
+            self.assertEqual(status, SUCCESS, msg)
+
+    @cleanupNet
     @permutations([[True], [False]])
     @RequireDummyMod
     @ValidateRunningAsRoot
@@ -360,6 +366,7 @@
             status, msg = self.vdsm_net.delNetwork(NETWORK_NAME)
             self.assertEqual(status, SUCCESS, msg)
 
+    @cleanupNet
     @permutations([[True], [False]])
     @RequireDummyMod
     @ValidateRunningAsRoot


-- 
To view, visit http://gerrit.ovirt.org/17941
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2fa9619a38acdfcc19f889329d375f868a3e921e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>


More information about the vdsm-patches mailing list