Change in vdsm[master]: Management network is now kept in main routing table

danken at redhat.com danken at redhat.com
Sun Aug 11 17:08:03 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Management network is now kept in main routing table
......................................................................


Management network is now kept in main routing table

Only the management network should add its default route
to the main routing table. Each NetDevice holds an IpConfig
instance who now holds defaultRoute='yes', 'no' or None.
Only the top level device will have a defaultRoute value.
When writing ifcfg files we check if we got a defaultRoute
value, if so we write it.

Patch Set 7 changed the implementation so that only the top
level device has DEFROUTE=yes/no in its ifcfg file.

Change-Id: I55c50269dd3d52fd058951200282c925a7014aca
Signed-off-by: Assaf Muller <amuller at redhat.com>
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=984028
Reviewed-on: http://gerrit.ovirt.org/17575
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/constants.py.in
M vdsm/configNetwork.py
M vdsm/netconf/__init__.py
M vdsm/netconf/ifcfg.py
M vdsm/netmodels.py
M vdsm/sourceRoute.py
6 files changed, 60 insertions(+), 28 deletions(-)

Approvals:
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Assaf Muller: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17575
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I55c50269dd3d52fd058951200282c925a7014aca
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list