Change in vdsm[master]: tests: setupNetworks convertVlanNetBridgeness, Mtus

asegurap at redhat.com asegurap at redhat.com
Sun Aug 11 12:57:29 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: tests: setupNetworks convertVlanNetBridgeness, Mtus
......................................................................


Patch Set 1: Code-Review-1

(8 comments)

....................................................
File tests/functional/networkTests.py
Line 388:                             NETWORK_NAME + '2':
Line 389:                             dict(bonding=BONDING_NAME, bridged=bridged,
Line 390:                                  vlan='200', mtu=MIDI)
Line 391:                             }
Line 392:                 bondings = {BONDING_NAME: dict(nics=[nics[0], nics[1]])}
nics[:2]
Line 393:                 elems = [NETWORK_NAME + '2', BONDING_NAME, nics[0], nics[1]]
Line 394:                 status, msg = self.vdsm_net.setupNetworks(networks, bondings,
Line 395:                                                           {})
Line 396: 


Line 389:                             dict(bonding=BONDING_NAME, bridged=bridged,
Line 390:                                  vlan='200', mtu=MIDI)
Line 391:                             }
Line 392:                 bondings = {BONDING_NAME: dict(nics=[nics[0], nics[1]])}
Line 393:                 elems = [NETWORK_NAME + '2', BONDING_NAME, nics[0], nics[1]]
delete
Line 394:                 status, msg = self.vdsm_net.setupNetworks(networks, bondings,
Line 395:                                                           {})
Line 396: 
Line 397:                 self.assertEquals(status, SUCCESS, msg)


Line 395:                                                           {})
Line 396: 
Line 397:                 self.assertEquals(status, SUCCESS, msg)
Line 398: 
Line 399:                 assertMtu(MIDI, *elems)
assertMtu(MIDI, NETWORK_NAME + '2', BONDING_NAME, nics[0], nics[1])
Line 400: 
Line 401:                 network = {NETWORK_NAME + '3':
Line 402:                            dict(bonding=BONDING_NAME, vlan='300', mtu=JUMBO,
Line 403:                                 bridged=bridged)}


Line 407:                 self.assertEquals(status, SUCCESS, msg)
Line 408: 
Line 409:                 self.assertTrue(self.vdsm_net.networkExists(NETWORK_NAME + '3',
Line 410:                                                             bridged=bridged))
Line 411:                 assertMtu(JUMBO, *elems)
or rather just:
    assertMtu(JUMBO, NETWORK_NAME + '3', BONDING_NAME, nics[0], nics[1])
you're not reusing elems anyway.
Line 412: 
Line 413:                 elems = [NETWORK_NAME + '2', BONDING_NAME, nics[0], nics[1]]
Line 414:                 status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME + '3':
Line 415:                                                            dict(remove=True)},


Line 409:                 self.assertTrue(self.vdsm_net.networkExists(NETWORK_NAME + '3',
Line 410:                                                             bridged=bridged))
Line 411:                 assertMtu(JUMBO, *elems)
Line 412: 
Line 413:                 elems = [NETWORK_NAME + '2', BONDING_NAME, nics[0], nics[1]]
move to 430.
Line 414:                 status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME + '3':
Line 415:                                                            dict(remove=True)},
Line 416:                                                           {}, {})
Line 417: 


Line 426:                                                           {}, {})
Line 427: 
Line 428:                 self.assertEquals(status, SUCCESS, msg)
Line 429: 
Line 430:                 assertMtu(MIDI, *elems)
same as 411.
Line 431: 
Line 432:                 # Add additional nic to the bond
Line 433:                 elems = [BONDING_NAME, nics[0], nics[1], nics[2]]
Line 434:                 status, msg = self.vdsm_net.setupNetworks({}, {BONDING_NAME:


Line 429: 
Line 430:                 assertMtu(MIDI, *elems)
Line 431: 
Line 432:                 # Add additional nic to the bond
Line 433:                 elems = [BONDING_NAME, nics[0], nics[1], nics[2]]
same.
Line 434:                 status, msg = self.vdsm_net.setupNetworks({}, {BONDING_NAME:
Line 435:                                                           dict(nics=nics)}, {})
Line 436: 
Line 437:                 self.assertEquals(status, SUCCESS, msg)


Line 435:                                                           dict(nics=nics)}, {})
Line 436: 
Line 437:                 self.assertEquals(status, SUCCESS, msg)
Line 438: 
Line 439:                 assertMtu(MIDI, *elems)
add from 433.
Line 440: 
Line 441:                 status, msg = self.vdsm_net.setupNetworks({NETWORK_NAME + '1':
Line 442:                                                            dict(remove=True)},
Line 443:                                                           {BONDING_NAME:


-- 
To view, visit http://gerrit.ovirt.org/17866
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8723b066228729807f7ab46c9fabad3ebff128b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list