Change in vdsm[master]: Handling ssl error specifically instead of printing all stac...

ybronhei at redhat.com ybronhei at redhat.com
Sun Aug 11 08:36:55 UTC 2013


Yaniv Bronhaim has uploaded a new change for review.

Change subject: Handling ssl error specifically instead of printing all stacktrace
......................................................................

Handling ssl error specifically instead of printing all stacktrace

During ssl error we're flooding the log with repeating stacktrace
prints, the exception message is enough, with the called address

Change-Id: I47556f62aef6f63a66fa47ecb4d693082da4dee1
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M vdsm/BindingXMLRPC.py
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/17917/1

diff --git a/vdsm/BindingXMLRPC.py b/vdsm/BindingXMLRPC.py
index fb65ad4..b0d771c 100644
--- a/vdsm/BindingXMLRPC.py
+++ b/vdsm/BindingXMLRPC.py
@@ -25,6 +25,7 @@
 import logging
 import libvirt
 import threading
+from M2Crypto.SSL import SSLError
 
 from vdsm import constants
 from vdsm import utils
@@ -66,9 +67,12 @@
             while self._enabled:
                 try:
                     self.server.handle_request()
+                except SSLError as e:
+                    self.log.error("xml-rpc SSL error: %s. from %s",
+                                   e.message, self.server.lastClient)
                 except Exception as e:
                     if e[0] != EINTR:
-                        self.log.error("xml-rpc handler exception",
+                        self.log.error("xml-rpc handler exception: %s",
                                        exc_info=True)
         self._thread = threading.Thread(target=threaded_start,
                                         name='BindingXMLRPC')


-- 
To view, visit http://gerrit.ovirt.org/17917
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I47556f62aef6f63a66fa47ecb4d693082da4dee1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list