Change in vdsm[ovirt-3.3]: Management network is now kept in main routing table

amuller at redhat.com amuller at redhat.com
Sun Aug 11 07:44:35 UTC 2013


Assaf Muller has posted comments on this change.

Change subject: Management network is now kept in main routing table
......................................................................


Patch Set 1:

(4 comments)

Thanks for the review Yaniv. Note: I pushed to oVirt-3.3 prematurely, so further work will be done on the master patch.

....................................................
File vdsm/configNetwork.py
Line 45: def objectivizeNetwork(bridge=None, vlan=None, bonding=None,
Line 46:                        bondingOptions=None, nics=None, mtu=None, ipaddr=None,
Line 47:                        netmask=None, gateway=None, bootproto=None,
Line 48:                        _netinfo=None, configurator=None, blockingdhcp=None,
Line 49:                        implicitBonding=None, defaultRoute=None, **opts):
I thought a bit about this and it should stay None. This method is used to construct the top level device when adding a network. In that case not passing a value would be an error, however this method is also used during delNetwork - In which case None would be the correct value as True/False have no meaning in the context.
Line 50:     """
Line 51:     Constructs an object hierarchy that describes the network configuration
Line 52:     that is passed in the parameters.
Line 53: 


....................................................
File vdsm/netconf/ifcfg.py
Line 542:                              bootproto, mtu, defaultRoute, **opts)
Line 543: 
Line 544:     @staticmethod
Line 545:     def _getIfaceConfValues(iface, _netinfo):
Line 546:         ipaddr, netmask, gateway, bootproto, _, defaultRoute =\
Done
Line 547:             iface.getIpConfig()
Line 548:         defaultRoute = ConfigWriter._toIfcfgFormat(defaultRoute)
Line 549:         mtu = iface.mtu
Line 550:         if _netinfo.ifaceUsers(iface.name):


....................................................
File vdsm/netmodels.py
Line 43:         raise NotImplementedError
Line 44: 
Line 45:     def getIpConfig(self):
Line 46:         try:
Line 47:             ipaddr, netmask, gateway, bootproto, async, defaultRoute =\
Done
Line 48:                 self.ip.getConfig()
Line 49:         except AttributeError:
Line 50:             ipaddr = netmask = gateway = bootproto = async = defaultRoute =\
Line 51:                 None


Line 333:             ipaddr = self.inet.address
Line 334:             netmask = self.inet.netmask
Line 335:             gateway = self.inet.gateway
Line 336:             defaultRoute = self.inet.defaultRoute
Line 337:         except AttributeError:
I'll talk to Antoni about this, he'd have a more informed opinion.
Line 338:             ipaddr = netmask = gateway = defaultRoute = None
Line 339:         return ipaddr, netmask, gateway, self.bootproto, self.async,\


-- 
To view, visit http://gerrit.ovirt.org/17844
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55c50269dd3d52fd058951200282c925a7014aca
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list