Change in vdsm[master]: tests: bondHwAddress, safeNetworkConfig, volatileConfig

asegurap at redhat.com asegurap at redhat.com
Sat Aug 10 21:21:42 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: tests: bondHwAddress, safeNetworkConfig, volatileConfig
......................................................................


Patch Set 1: Verified-1 Code-Review-1

(1 comment)

I found the reason!!!

....................................................
File tests/functional/utils.py
Line 114:             # cleanup
Line 115:             restoreNetConfig()
Line 116:             raise
Line 117:     return wrapper
Line 118: 
The reason the tests fail is because restoreNetConfig is
netinfo altering. So that after it VdsProxy's netinfo should be replaced with a new one.

How to go about it... I guess I would move it inside of VdsProxy and add the @netinfo_altering
Line 119: 
Line 120: def restoreNetConfig():
Line 121:     cmd_service = [service.cmd, "vdsm-restore-net-config", "restart"]
Line 122:     utils.execCmd(cmd_service, sudo=True)


-- 
To view, visit http://gerrit.ovirt.org/17640
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b035155ef715d8456d9c4658ad2cb7ee76c80d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list