Change in vdsm[master]: refactoring: rename variable in getVlanID function

danken at redhat.com danken at redhat.com
Fri Aug 9 12:39:48 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: refactoring: rename variable in getVlanID function
......................................................................


refactoring: rename variable in getVlanID function

In the function getVlanID we're using id as a variable
name, proposed refactoring changes this variable name,
so we don't redefine the built-in function 'id'.

Change-Id: I16f28ea07c3ba0a704a094f0fa08d4e03b07a9dc
Signed-off-by: Giuseppe Vallarelli <gvallare at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/17830
Reviewed-by: Antoni Segura Puimedon <asegurap at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netinfo.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Giuseppe Vallarelli: Verified
  Antoni Segura Puimedon: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17830
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I16f28ea07c3ba0a704a094f0fa08d4e03b07a9dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list