Change in vdsm[master]: Fixing return value of function 'start' in init script

danken at redhat.com danken at redhat.com
Thu Aug 8 13:43:57 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fixing return value of function 'start' in init script
......................................................................


Fixing return value of function 'start' in init script

During fixing lock mechanism (http://gerrit.ovirt.org/#/c/17662) we
change to use locked_start function, this set to return "start ||
release_lock && return 1". Without surrender the second part with brackets,
this function returns always 1. This 1 returns as exit code and fail external
operations as hostDeploy.

Change-Id: If9a9e89594f136d8e7b41b713e43d64f3702d454
Signed-off-by: Ohad Basan <obasan at redhat.com>
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/17828
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/vdsmd.init.in
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Verified; Looks good to me, but someone else must approve
  Ohad Basan: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17828
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If9a9e89594f136d8e7b41b713e43d64f3702d454
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi at redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list