Change in vdsm[master]: Management network is now kept in main routing table

danken at redhat.com danken at redhat.com
Wed Aug 7 17:02:36 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Management network is now kept in main routing table
......................................................................


Patch Set 10: Code-Review+1

(1 comment)

....................................................
File vdsm/netconf/ifcfg.py
Line 449:         '''
Line 450:         defaultRoute can come from ifcfg files due to _getIfaceConfValues,
Line 451:         in which case it can be None if DEFROUTE did not exist in the file,
Line 452:         or 'yes|no'. Otherwise, it's either True or False and comes from
Line 453:         a device's IpConfig instance.
not so pretty... but I suppose that adding 4 calls to _fromIfcfgFormat() would not be prettier.
Line 454:         '''
Line 455:         if defaultRoute is None:
Line 456:             return None
Line 457:         return 'yes' if defaultRoute in (True, 'yes') else 'no'


-- 
To view, visit http://gerrit.ovirt.org/17575
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55c50269dd3d52fd058951200282c925a7014aca
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list