Change in vdsm[master]: Source Route script now checks that the DHCP response is whole

danken at redhat.com danken at redhat.com
Wed Aug 7 15:41:25 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Source Route script now checks that the DHCP response is whole
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

....................................................
File vdsm/sourceRoute.sh
Line 10:     fi
Line 11: }
Line 12: 
Line 13: sourceRoute_restore() {
Line 14:     echo "remove" "$interface" > \
do we trust $interface to be ever non-zero here?
Line 15:         /var/run/vdsm/sourceRoutes/$timeStamp


-- 
To view, visit http://gerrit.ovirt.org/17789
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3400b1ef736082ed3d5c42edf8ed5d66e94cce98
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list