Change in vdsm[master]: Management network is now kept in main routing table

danken at redhat.com danken at redhat.com
Wed Aug 7 14:58:53 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: Management network is now kept in main routing table
......................................................................


Patch Set 9: Code-Review+1

(1 comment)

....................................................
File vdsm/configNetwork.py
Line 195: 
Line 196:     bootproto = options.pop('bootproto', None)
Line 197: 
Line 198:     defaultRoute = \
Line 199:         True if network == constants.MANAGEMENT_NETWORK else False
equivalent to

  (network == constants.MANAGEMENT_NETWORK)

but let it be.
Line 200: 
Line 201:     netEnt = objectivizeNetwork(network if bridged else None, vlan, bonding,
Line 202:                                 bondingOptions, nics, mtu, ipaddr, netmask,
Line 203:                                 gateway, bootproto, _netinfo, configurator,


-- 
To view, visit http://gerrit.ovirt.org/17575
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55c50269dd3d52fd058951200282c925a7014aca
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list