Change in vdsm[master]: netinfo getIfaceCfg cleanup, naked except removal

danken at redhat.com danken at redhat.com
Wed Aug 7 14:05:07 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: netinfo getIfaceCfg cleanup, naked except removal
......................................................................


netinfo getIfaceCfg cleanup, naked except removal

getIfaceCfg was using shlex but not taking advantage that it
can handle comments better than we were doing (inline comments
and such). This patch makes heavier use of it as well as removes
the naked exceptions that were catching BaseExceptions (which
is usually evil).

Change-Id: I26112f41c72dbfb3b9c8cdb181cf731297d0e072
Signed-off-by: Antoni S. Puimedon <asegurap at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/17760
Reviewed-by: Giuseppe Vallarelli <gvallare at redhat.com>
Reviewed-by: Mark Wu <wudxw at linux.vnet.ibm.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netinfo.py
1 file changed, 10 insertions(+), 15 deletions(-)

Approvals:
  Giuseppe Vallarelli: Looks good to me, but someone else must approve
  Antoni Segura Puimedon: Verified
  Mark Wu: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17760
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I26112f41c72dbfb3b9c8cdb181cf731297d0e072
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list