Change in vdsm[master]: VDSM now writes its version number in VDSM-generated ifcfg f...

amuller at redhat.com amuller at redhat.com
Wed Aug 7 07:42:29 UTC 2013


Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

    http://gerrit.ovirt.org/17738

to review the following change.

Change subject: VDSM now writes its version number in VDSM-generated ifcfg files
......................................................................

VDSM now writes its version number in VDSM-generated ifcfg files

Take 2!
This is a fix so that the code is identical in master and ovirt-3.3
branch.

Change-Id: Ida8a540356e04d86eb19e05149861d800d8f7314
Signed-off-by: Assaf Muller <amuller at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/17566
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm/netconf/ifcfg.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/17738/1

diff --git a/vdsm/netconf/ifcfg.py b/vdsm/netconf/ifcfg.py
index bf0e738..290d70c 100644
--- a/vdsm/netconf/ifcfg.py
+++ b/vdsm/netconf/ifcfg.py
@@ -181,7 +181,8 @@
 
 
 class ConfigWriter(object):
-    CONFFILE_HEADER = '# automatically generated by vdsm'
+    CONFFILE_HEADER = '# Generated by VDSM version %s' %\
+                      dsaversion.raw_version_revision
     DELETED_HEADER = '# original file did not exist'
 
     def __init__(self):
@@ -447,8 +448,7 @@
                         gateway=None, bootproto=None, mtu=None, onboot='yes',
                         **kwargs):
         """ Create ifcfg-* file with proper fields per device """
-        cfg = """# Generated by VDSM version %s\n""" % \
-              dsaversion.raw_version_revision
+        cfg = self.CONFFILE_HEADER + '\n'
 
         cfg += """DEVICE=%s\nONBOOT=%s\n""" % (pipes.quote(name),
                                                pipes.quote(onboot))


-- 
To view, visit http://gerrit.ovirt.org/17738
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida8a540356e04d86eb19e05149861d800d8f7314
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list