Change in vdsm[master]: Lock init script when vdsmd starts up until the service is s...

abaron at redhat.com abaron at redhat.com
Tue Aug 6 20:27:36 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Lock init script when vdsmd starts up until the service is stopped
......................................................................


Patch Set 5:

(1 comment)

....................................................
File vdsm/vdsmd.init.in
Line 108: acquire_lock() {
Line 109:     if [ -f "$LOCK_FILE" ]; then
Line 110:         return 1
Line 111:     fi
Line 112:     touch "$LOCK_FILE"
alternatively take an flock on another (pid?) file and only under protection of that check existence and avoid race?
e.g. http://tobrunet.ch/2013/01/follow-up-bash-script-locking-with-flock/
Line 113:     return 0
Line 114: }
Line 115: 
Line 116: release_lock() {


-- 
To view, visit http://gerrit.ovirt.org/17662
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bf346946179e5bb2a91ab33d6b917f280a90a57
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list