Change in vdsm[master]: clientIF: maintain list of vm's domains inside the vm object

danken at redhat.com danken at redhat.com
Tue Aug 6 17:44:10 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: clientIF: maintain list of vm's domains inside the vm object
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

....................................................
File vdsm/vm.py
Line 2082:                     # A destroy request has been issued, exit early
Line 2083:                     break
Line 2084:                 drive['path'] = self.cif.prepareVolumePath(drive, self.id)
Line 2085:             if drive['device'] == 'disk' and isVdsmImage(drive):
Line 2086:                 domains.append(drive['domainID'])
we care about the multiplicity of each domain - we need to keep an sdID on hotunplug if the VM has two references to it.
Line 2087:         else:
Line 2088:             self.sdIds.extend(domains)
Line 2089:             # Now we got all the resources we needed
Line 2090:             self.startDisksStatsCollection()


-- 
To view, visit http://gerrit.ovirt.org/17664
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4a19380c26ff4b6b697455e060dab4c651ff3f7c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list