Change in vdsm[master]: Fix log level for failures in execCmd

abaron at redhat.com abaron at redhat.com
Tue Aug 6 14:46:47 UTC 2013


Ayal Baron has posted comments on this change.

Change subject: Fix log level for failures in execCmd
......................................................................


Patch Set 2:

Saggi, the current default behaviour of logging errors when we see them seems like the more sane option to me than having the caller remember every time to log.  What you're suggesting is that in the *extremely* few cases where we actually do not care about this failing (or in fact expect it to fail) we wouldn't have to change anything and in the rest of the cases we'd have to remember everytime to log.

-- 
To view, visit http://gerrit.ovirt.org/13362
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e5c3ac5bde06ed9083bc9c1662d3b4eddc85034
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list