Change in vdsm[master]: vm: new parameter 'protected' for vm creation

fsimonce at redhat.com fsimonce at redhat.com
Tue Aug 6 13:43:30 UTC 2013


Federico Simoncelli has posted comments on this change.

Change subject: vm: new parameter 'protected' for vm creation
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/vm.py
Line 2687:         domxml.appendGraphics()
Line 2688: 
Line 2689:         self._appendDevices(domxml)
Line 2690: 
Line 2691:         if (config.getboolean('irs', 'use_volume_leases')
Actually I wonder if we could remove use_volume_leases
Line 2692:                 or self.isProtected()):
Line 2693: 
Line 2694:             for drive in self._devices[DISK_DEVICES][:]:
Line 2695:                 if not hasattr(drive, 'volumeChain'):


-- 
To view, visit http://gerrit.ovirt.org/17714
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9429ead45caac1178957a33393642817db59508f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list