Change in vdsm[master]: sp: asynchronous convertDomain in activateSD

smizrahi at redhat.com smizrahi at redhat.com
Tue Aug 6 11:07:50 UTC 2013


Saggi Mizrahi has posted comments on this change.

Change subject: sp: asynchronous convertDomain in activateSD
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

....................................................
File vdsm/storage/hsm.py
Line 3395:     @public
Line 3396:     def upgradeStoragePool(self, spUUID, targetDomVersion):
Line 3397:         targetDomVersion = int(targetDomVersion)
Line 3398:         pool = self.getPool(spUUID)
Line 3399:         # TODO: this request should become asynchronous using a task
No it shouldn't. Pool upgrade progress is not reported by design.
Line 3400:         pool._upgradeMasterDomain(targetDomVersion)
Line 3401:         pool._upgradeRegularDomains()
Line 3402:         return {"upgradeStatus": "started"}
Line 3403: 


Line 3397:         targetDomVersion = int(targetDomVersion)
Line 3398:         pool = self.getPool(spUUID)
Line 3399:         # TODO: this request should become asynchronous using a task
Line 3400:         pool._upgradeMasterDomain(targetDomVersion)
Line 3401:         pool._upgradeRegularDomains()
This is what _upgradePool() did both things. I don't see why exposing the change outward is needed. Leaving it _upgradePool() and having it call these two methods would have done the trick.
Line 3402:         return {"upgradeStatus": "started"}
Line 3403: 
Line 3404:     @public
Line 3405:     def repoStats(self, options=None):


-- 
To view, visit http://gerrit.ovirt.org/13634
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I679a992f689ee6ae97c82c267d0da69b4f0e6725
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list