Change in vdsm[master]: vm: Remove redundant if statements in hotUnplugDisk

ykaplan at redhat.com ykaplan at redhat.com
Tue Aug 6 08:40:02 UTC 2013


Yeela Kaplan has posted comments on this change.

Change subject: vm: Remove redundant if statements in hotUnplugDisk
......................................................................


Patch Set 1:

(1 comment)

....................................................
File vdsm/vm.py
Line 3282:             if drv.path == diskParams['path']:
Line 3283:                 drive = drv
Line 3284:                 break
Line 3285: 
Line 3286:         if not drive:
Done
Line 3287:             self.log.error("Hotunplug disk failed - Disk not found: %s",
Line 3288:                            diskParams)
Line 3289:             return {'status': {'code': errCode['hotunplugDisk']
Line 3290:                                               ['status']['code'],


-- 
To view, visit http://gerrit.ovirt.org/17669
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2eb36e58526b0ce585cb1ea34dcca34921459a20
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list