Change in vdsm[master]: clientIF: maintain list of vm's domains inside the vm object
zhshzhou at linux.vnet.ibm.com
zhshzhou at linux.vnet.ibm.com
Tue Aug 6 07:25:11 UTC 2013
Zhou Zheng Sheng has posted comments on this change.
Change subject: clientIF: maintain list of vm's domains inside the vm object
......................................................................
Patch Set 1:
(1 comment)
....................................................
File vdsm/vm.py
Line 2074: def isDisksStatsCollectionEnabled(self):
Line 2075: return self._volumesPrepared
Line 2076:
Line 2077: def preparePaths(self, drives):
Line 2078: domains = []
I think the "set" data type is better for "self.domainIds" and "domains". It guarantees no duplicated entries being added. Is there some good reasons to use list here?
Line 2079: for drive in drives:
Line 2080: with self._volPrepareLock:
Line 2081: if self.destroyed:
Line 2082: # A destroy request has been issued, exit early
--
To view, visit http://gerrit.ovirt.org/17664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a19380c26ff4b6b697455e060dab4c651ff3f7c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshzhou at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list