Change in vdsm[ovirt-3.3]: Crash fix for migrations that involve devices with no aliases

danken at redhat.com danken at redhat.com
Tue Aug 6 06:57:19 UTC 2013


Dan Kenigsberg has submitted this change and it was merged.

Change subject: Crash fix for migrations that involve devices with no aliases
......................................................................


Crash fix for migrations that involve devices with no aliases

The destination host updates the device XML cache for every
device by scanning the VM's XML that was received from
the source host, breaking it apart and placing each device's
XML into its Device class instance. The identification
of devices is done via the alias pulled from the VM conf. Some
devices don't have aliases pulled from libvirt. In any case,
migrations should succeed (instead of crashing VDSM) and
devices with no aliases should be dealt with in a separate patch.

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988065
Change-Id: I3f05a945c2f3507d5571ac3f3b212e59a30bdfae
Signed-off-by: Assaf Muller <amuller at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/17515
Reviewed-by: Michal Skrivanek <michal.skrivanek at redhat.com>
Reviewed-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Tested-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: http://gerrit.ovirt.org/17685
---
M vdsm/vm.py
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit http://gerrit.ovirt.org/17685
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f05a945c2f3507d5571ac3f3b212e59a30bdfae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>


More information about the vdsm-patches mailing list