Change in vdsm[master]: macspoof hooks: new hook script to enable macspoof filtering...

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Tue Aug 6 02:45:55 UTC 2013


Mark Wu has posted comments on this change.

Change subject: macspoof hooks: new hook script to enable macspoof filtering per vnic.
......................................................................


Patch Set 1: Code-Review-1

Giuseppe,
I think this problem should be resolved on engine side. We could have a checkbox for whether mac spoofing is eanbled for a vnic. If it's disabled,  it shouldn't add the device attribute of 'filter', then vdsm will not apply the filter on the vnic. For me, it doesn't make sense to use hook to tune options already included in API. How do you think of it?
Thanks.

-- 
To view, visit http://gerrit.ovirt.org/17678
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb3e7bec7ce400dddc6f4e649b7d21dfe5010631
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list