Change in vdsm[master]: netconf: Add dhcp support for iproute2 configurator

asegurap at redhat.com asegurap at redhat.com
Mon Aug 5 16:20:44 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: netconf: Add dhcp support for iproute2 configurator
......................................................................


Patch Set 4:

(1 comment)

....................................................
File vdsm/netconf/iproute2.py
Line 172:         if rc:
Line 173:             logging.error('Restore network configuration failed: %s', err)
Line 174: 
Line 175: 
Line 176: class DhcpClient():
I think it could make sense to have this class in it's own module just like ipwrapper is.
Line 177:     PID_FILE = '/var/run/dhclient-%s.pid'
Line 178:     LEASE_DIR = '/var/lib/dhclient/'
Line 179:     LEASE_FILE = LEASE_DIR + 'dhclient-%s.lease'
Line 180:     DHCLIENT = CommandPath('dhclient', '/sbin/dhclient')


-- 
To view, visit http://gerrit.ovirt.org/15492
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea88e8693e47fa51edb89c33344332c88c5c964d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list