Change in vdsm[master]: tests: bondHwAddress, safeNetworkConfig, volatileConfig

gvallare at redhat.com gvallare at redhat.com
Mon Aug 5 08:30:47 UTC 2013


Giuseppe Vallarelli has posted comments on this change.

Change subject: tests: bondHwAddress, safeNetworkConfig, volatileConfig
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Some small fixes are needed.

....................................................
File tests/functional/networkTests.py
Line 713:             self.assertEquals(status, SUCCESS, msg)
Line 714: 
Line 715:             self.vdsm_net.networkExists(NETWORK_NAME, bridged=bridged)
Line 716: 
Line 717:             restoreNetConfig()
Simply assertion error, meaning that the created network is still there.
Line 718:             # Wait for VDSM to become responsive again
Line 719:             utils.retry(lambda: self.assertEquals(
Line 720:                         SUCCESS, self.vdsm_net.ping()), tries=30)
Line 721: 


....................................................
File tests/functional/utils.py
Line 250: 
Line 251:     def setSafeNetworkConfig(self):
Line 252:         self.vdscli.setSafeNetworkConfig()
Line 253: 
Line 254:     def restartDaemon(self):
Makes sense, thanks.
Line 255:         cmd_service = [service.cmd, "vdsmd", "restart"]
Line 256:         utils.execCmd(cmd_service, sudo=True)
Line 257: 
Line 258:     def ping(self):


-- 
To view, visit http://gerrit.ovirt.org/17640
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b035155ef715d8456d9c4658ad2cb7ee76c80d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvallare at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list